Add unicode blocks and char properties in Java#11
Closed
haozhun wants to merge 1 commit intojruby:masterfrom
Closed
Add unicode blocks and char properties in Java#11haozhun wants to merge 1 commit intojruby:masterfrom
haozhun wants to merge 1 commit intojruby:masterfrom
Conversation
148fa40 to
5a41566
Compare
4da1493 to
22263ef
Compare
Member
|
This never got merged in and then years went by... This seems like it might still be valid, but it doesn't merge now and LOTS of improvements have been made in Joni since then. If you can update this, please submit a new PR and we'll get it merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds blocks and character properties that are available in java.pattern regular expression but not yet available in jcodings (or joni). It modifies the generator script to accept a configuration file besides ruby source code.
Please review. Thanks.